Skip to content

Add spfx-install script with metadata and details #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 3, 2025

Conversation

DonKirkham
Copy link
Contributor

@DonKirkham DonKirkham commented Apr 24, 2025

I think I updated everything correctly. Let me know if I need to change anything.

@pkbullock
Copy link
Collaborator

pkbullock commented Apr 30, 2025

Hey Don, I see this is draft, do you need any help?

@DonKirkham
Copy link
Contributor Author

DonKirkham commented Apr 30, 2025 via email

@pkbullock
Copy link
Collaborator

No worries, lol those badges are SWEET!

@DonKirkham DonKirkham marked this pull request as ready for review May 1, 2025 10:03
@DonKirkham
Copy link
Contributor Author

OK, I made a change to include the latest SPFx version and submitted.

@pkbullock
Copy link
Collaborator

Hey @DonKirkham, just checking something, this doesn't use CLI for Microsoft365 does it? Just the site doesn't offer a bash category.

@DonKirkham
Copy link
Contributor Author

No, it is a straight shell script. Most of it would run in a PowerShell terminal session, but there are some specific commands that are for Bash. I noticed there was not a Bash/Shell category, which is one of the reasons it has taken so long to submit it. I did see a backlog item to expand to other CLIs, so didn't know if a Shell script category might be in the cards. If it doesn't fit, no big deal. If I would incorporate CLI for Microsoft365, I would but don't see a place to incorporate it.

@pkbullock
Copy link
Collaborator

I have added the new categories to the site see #830 so what ill do is process your sample now and tweak with the new categories 🥳

@DonKirkham
Copy link
Contributor Author

Thanks Paul! 🎉🎆
SnoopSnoopyGIF

@pkbullock pkbullock merged commit a73b16a into pnp:main May 3, 2025
@pkbullock
Copy link
Collaborator

Haha, thanks Don, great sample, thank you for sharing. 🥳🎉 It will be live shortly.

@DonKirkham DonKirkham deleted the spfx-install branch May 4, 2025 14:56
@DonKirkham
Copy link
Contributor Author

DonKirkham commented May 4, 2025

I have always wanted to create a PowerShell version of the script for Windows users. Adam W mentioned nvs in a LinkedIn comment and it dawned on me that I can rewrite this script to use cross-platform nvs and then convert it to PowerShell! Cross Platform with one script!!!

So many ideas, so little time!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants