-
Notifications
You must be signed in to change notification settings - Fork 156
Add spfx-install script with metadata and details #826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey Don, I see this is draft, do you need any help? |
I don't think so. I filled everything out, but wanted to review one more time before submitting. Honestly, I was waiting until May 1st to get one of those sweet May badges! 🙂
…________________________________
From: Paul Bullock ***@***.***>
Sent: Wednesday, April 30, 2025 2:19 AM
To: pnp/script-samples ***@***.***>
Cc: Don Kirkham ***@***.***>; Author ***@***.***>
Subject: Re: [pnp/script-samples] Add spfx-install script with metadata and details (PR #826)
[https://avatars.githubusercontent.com/u/8781041?s=20&v=4]pkbullock left a comment (pnp/script-samples#826)<#826 (comment)>
Hey Don, I see this is draft, do you need any help?
—
Reply to this email directly, view it on GitHub<#826 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACB3AT3XQ7PUMEXPHTC2FBT24B2QLAVCNFSM6AAAAAB3ZLYDVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNBRGA2DKMJSGI>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
No worries, lol those badges are SWEET! |
OK, I made a change to include the latest SPFx version and submitted. |
Hey @DonKirkham, just checking something, this doesn't use CLI for Microsoft365 does it? Just the site doesn't offer a bash category. |
No, it is a straight shell script. Most of it would run in a PowerShell terminal session, but there are some specific commands that are for Bash. I noticed there was not a Bash/Shell category, which is one of the reasons it has taken so long to submit it. I did see a backlog item to expand to other CLIs, so didn't know if a Shell script category might be in the cards. If it doesn't fit, no big deal. If I would incorporate CLI for Microsoft365, I would but don't see a place to incorporate it. |
I have added the new categories to the site see #830 so what ill do is process your sample now and tweak with the new categories 🥳 |
Haha, thanks Don, great sample, thank you for sharing. 🥳🎉 It will be live shortly. |
I have always wanted to create a PowerShell version of the script for Windows users. Adam W mentioned nvs in a LinkedIn comment and it dawned on me that I can rewrite this script to use cross-platform nvs and then convert it to PowerShell! Cross Platform with one script!!! So many ideas, so little time!!!! |
I think I updated everything correctly. Let me know if I need to change anything.